Skip to content

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Oct 28, 2025

Hi all,

This pull request contains a backport of commit 68b6e11e from the openjdk/jdk repository.

The commit being backported was authored by Yasumasa Suenaga on 10 Jul 2021 and was reviewed by Erik Joelsson, Dean Long and Kim Barrett.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8270083 needs maintainer approval

Issue

  • JDK-8270083: -Wnonnull errors happen with GCC 11.1.1 (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4132/head:pull/4132
$ git checkout pull/4132

Update a local copy of the PR:
$ git checkout pull/4132
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4132/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4132

View PR using the GUI difftool:
$ git pr show -t 4132

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4132.diff

Using Webrev

Link to Webrev Comment

Reviewed-by: erikj, dlong, kbarrett
@mrserb mrserb changed the title 8270083: -Wnonnull errors happen with GCC 11.1.1 Backport 68b6e11e481349e40014aa4593a53ae2ea74aedc Oct 28, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 28, 2025

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270083: -Wnonnull errors happen with GCC 11.1.1

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 68b6e11e481349e40014aa4593a53ae2ea74aedc 8270083: -Wnonnull errors happen with GCC 11.1.1 Oct 28, 2025
@openjdk
Copy link

openjdk bot commented Oct 28, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 28, 2025
@mrserb
Copy link
Member Author

mrserb commented Oct 29, 2025

This patch, along with several similar ones, was removed from the mainline as part of JDK-8291895. That issue also references other related tickets titled “Undefined Behaviour in class XX,” which as of now remain unfixed in 17u. Therefore, I think this patch should be merged first, as it will also simplify future backports related to Xcode 16+.

@shipilev @theRealAph please take a look

@mrserb mrserb marked this pull request as ready for review October 29, 2025 02:42
@openjdk
Copy link

openjdk bot commented Oct 29, 2025

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 29, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 29, 2025

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this looks reasonable. Toolchain support backports are annoying, but unfortunately necessary for long-term maintenance.

@mrserb
Copy link
Member Author

mrserb commented Oct 29, 2025

/approval request
Clean backport. The patch updates the code to handle certain warnings during compilation. It is part of the ongoing effort to migrate JDK 17 to the new toolchain, including Xcode 16, and will make further patches cleaner.

@openjdk
Copy link

openjdk bot commented Oct 29, 2025

@mrserb
8270083: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 29, 2025
@mrserb
Copy link
Member Author

mrserb commented Oct 30, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Oct 30, 2025

Going to push as commit 5d35f53.
Since your change was applied there have been 13 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 30, 2025
@openjdk openjdk bot closed this Oct 30, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 30, 2025
@openjdk
Copy link

openjdk bot commented Oct 30, 2025

@mrserb Pushed as commit 5d35f53.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the backport-mrserb-7743345f-master branch October 31, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants