-
Notifications
You must be signed in to change notification settings - Fork 232
8270083: -Wnonnull errors happen with GCC 11.1.1 #4132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewed-by: erikj, dlong, kbarrett
|
👋 Welcome back serb! A progress list of the required criteria for merging this PR into |
|
@mrserb This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
This patch, along with several similar ones, was removed from the mainline as part of JDK-8291895. That issue also references other related tickets titled “Undefined Behaviour in class XX,” which as of now remain unfixed in 17u. Therefore, I think this patch should be merged first, as it will also simplify future backports related to Xcode 16+. @shipilev @theRealAph please take a look |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this looks reasonable. Toolchain support backports are annoying, but unfortunately necessary for long-term maintenance.
|
/approval request |
|
/integrate |
|
Going to push as commit 5d35f53.
Your commit was automatically rebased without conflicts. |
Hi all,
This pull request contains a backport of commit 68b6e11e from the openjdk/jdk repository.
The commit being backported was authored by Yasumasa Suenaga on 10 Jul 2021 and was reviewed by Erik Joelsson, Dean Long and Kim Barrett.
Thanks!
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4132/head:pull/4132$ git checkout pull/4132Update a local copy of the PR:
$ git checkout pull/4132$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4132/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4132View PR using the GUI difftool:
$ git pr show -t 4132Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4132.diff
Using Webrev
Link to Webrev Comment